Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Add automake to linux dependencies #6138

Merged
merged 1 commit into from
Sep 24, 2024
Merged

build: Add automake to linux dependencies #6138

merged 1 commit into from
Sep 24, 2024

Conversation

nullun
Copy link
Contributor

@nullun nullun commented Sep 19, 2024

I just setup a brand new Linux machine (Debian 12) and ran through the usual install steps. But upon doing make I hit the following.

...
./scripts/check_golang_version.sh build
mkdir -p crypto/copies/linux/arm64
cp -R crypto/libsodium-fork/. crypto/copies/linux/arm64/libsodium-fork
cd crypto/copies/linux/arm64/libsodium-fork && \
	./autogen.sh --prefix /home/steve/go-algorand/crypto/libs/linux/arm64 && \
	./configure --disable-shared --prefix="/home/steve/go-algorand/crypto/libs/linux/arm64"  && \
	make && \
	make install
automake is required, but wasn't found on this system
make: *** [Makefile:169: crypto/libs/linux/arm64/lib/libsodium.a] Error 1

As for arch it seems as though jq has its own dependency on automake and would be installed, but I'm not sure about Fedora.

@nullun nullun changed the title Add automake to linux dependencies build: Add automake to linux dependencies Sep 19, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.22%. Comparing base (e1eb46a) to head (6f98fc6).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6138      +/-   ##
==========================================
- Coverage   56.22%   56.22%   -0.01%     
==========================================
  Files         494      494              
  Lines       69954    69954              
==========================================
- Hits        39334    39332       -2     
+ Misses      27944    27942       -2     
- Partials     2676     2680       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@algorandskiy
Copy link
Contributor

Closing/reopening to retrigger license/cla

@algorandskiy algorandskiy reopened this Sep 19, 2024
@algorandskiy algorandskiy merged commit c649ddb into algorand:master Sep 24, 2024
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algorandskiy algorandskiy algorandskiy approved these changes

@cce cce cce approved these changes

@onetechnical onetechnical Awaiting requested review from onetechnical

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nullun @algorandskiy @cce